Feat/proxy callbacks #191
Closed
Feat/proxy callbacks #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gentlementlegen @whilefoo Fancy a peak? Still to accommodate actions, fix failing tests and will do that tmrw but it's a matter of replicating the code pretty much (will try to avoid actually copy/pasting). Anything sticking out so far that's a deal breaker? Also am I correct in thinking the |
whilefoo
reviewed
Nov 6, 2024
|
|
There was a problem hiding this comment.
Is this needed since we moved the SDK out?
gentlementlegen
requested changes
Nov 10, 2024
|
Makes sense to PR the SDK so I'll need to redo this PR |
|
ubiquity-os-marketplace/command-ask#26 (comment) If this PR is a priority can the task be priced and I'll be happy to re-do things (once the location of where the SDK will live is decided) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ubiquity-os/plugin-sdk#33
CallbackBuilderclass to help build theproxyCallbacksobjectcreatePlugintakesCallbackBuilderinstead ofhandler()/sdkand/typesright now but easy to add othersQA: ubq-testing/qa-plugin#1
Building callbacks:
Callback signature:
Clean package.json per dist dir:
